Re: [next:master 2131/2422] kernel/sys.c:1888 prctl_set_mm_map() warn: maybe return -EFAULT instead of the bytes remaining?

On Wed, Aug 27, 2014 at 02:09:09PM +0400, Cyrill Gorcunov wrote:

Not really sure I'm follow. @error is error code either 0 (on success) or
any other if some problem happened.

It's complaining about this:

kernel/sys.c
  1846          if (prctl_map.auxv_size) {
  1847                  up_read(&mm->mmap_sem);
  1848                  memset(user_auxv, 0, sizeof(user_auxv));
  1849                  error = copy_from_user(user_auxv,
  1850                                         (const void __user *)prctl_map.auxv,
  1851                                         prctl_map.auxv_size);
  1852                  down_read(&mm->mmap_sem);
  1853                  if (error)
  1854                          goto out;
  1855          }

It should say:

			if (error) {
				error = -EFAULT;
				goto out;
			}

regards,
dan carpenter

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>