Re: [PATCH 1/1] x86: add phys addr validity check for /dev/mem mmap

On 08/14/2014 09:36 AM, Dave Hansen wrote:

Thanks for dredging this back up!

On 08/14/2014 07:18 AM, Frantisek Hrbata wrote:

quoted

+int valid_phys_addr_range(phys_addr_t addr, size_t count)
+{
+	return addr + count <= __pa(high_memory);
+}

Is this correct on 32-bit?  It would limit /dev/mem to memory below 896MB.

Last I checked, /dev/mem was already broken for highmem... which is
actually a problem.  I would prefer to see it fixed.

	-hpa

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>