Re: [PATCH v2 5/8] mm/isolation: change pageblock isolation logic to fix freepage counting bugs
From: Vlastimil Babka <hidden>
Date: 2014-08-12 10:58:44
Also in:
lkml
On 08/12/2014 08:43 AM, Minchan Kim wrote:
quoted
--- a/mm/page_alloc.c +++ b/mm/page_alloc.c@@ -571,7 +571,7 @@ static inline int page_is_buddy(struct page *page, struct page *buddy, * -- nyc */ -static inline void __free_one_page(struct page *page, +void __free_one_page(struct page *page,no inline any more. :(
That could be hopefully done differently without killing this property.
Personally, it is becoming increasingly clear that it would be better to add some hooks for isolateed pages to be sure to fix theses problems without adding more complicated logic.
Might be a valid argument but please do read the v1 discussions and then say if you still hold the opinion. Or maybe you will get a better picture afterwards and see a more elegant solution :) Vlastimil -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>