Thread (9 messages) 9 messages, 2 authors, 2014-08-05

Re: [patch 2/3] mm, oom: remove unnecessary check for NULL zonelist

From: Johannes Weiner <hannes@cmpxchg.org>
Date: 2014-08-01 13:35:33
Also in: lkml

On Fri, Aug 01, 2014 at 02:10:37AM -0700, David Rientjes wrote:
On Thu, 31 Jul 2014, Johannes Weiner wrote:
quoted
out_of_memory() wants the zonelist that was used during allocation,
not just the random first node's zonelist that's simply picked to
serialize page fault OOM kills system-wide.

This would even change how panic_on_oom behaves for page fault OOMs
(in a completely unpredictable way) if we get CONSTRAINED_CPUSET.

This change makes no sense to me.
Allocations during fault will be constrained by the cpuset's mems, if we 
are oom then why would we panic when panic_on_oom == 1?
Can you please address the concerns I raised?

And please describe user-visible changes in the changelog.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help