Re: [PATCH 4/8] mmu_notifier: pass through vma to invalidate_range and invalidate_page v2

On Wed, Jul 09, 2014 at 06:41:31PM +0200, Joerg Roedel wrote:

On Tue, Jul 08, 2014 at 06:00:01PM -0400, j.glisse@gmail.com wrote:

quoted

New user of the mmu_notifier interface need to lookup vma in order to
perform the invalidation operation. Instead of redoing a vma lookup
inside the callback just pass through the vma from the call site where
it is already available.

Why do you need to lookup the vma during the invalidation operation?
Given that invalidate_range_start/end can be expensive to implement on
the call-back side those calls should happen less instead of more
frequently.

To do different thing if vma is file backed and depending on the block
device the file is in.

Cheers,
Jerome

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>