Re: [next:master 156/212] fs/binfmt_elf.c:158:18: note: in expansion of macro 'min'

On 06/26/2014 06:44 AM, David Rientjes wrote:

On Wed, 25 Jun 2014, Jeff Liu wrote:

quoted

quoted

   fs/binfmt_elf.c: In function 'get_atrandom_bytes':
   include/linux/kernel.h:713:17: warning: comparison of distinct pointer types lacks a cast
     (void) (&_min1 == &_min2);  \
                    ^

quoted

quoted

fs/binfmt_elf.c:158:18: note: in expansion of macro 'min'

      size_t chunk = min(nbytes, sizeof(random_variable));

I remember we have the same report on arch mn10300 about half a year ago, but the code
is correct. :)

Casting the sizeof operator to size_t would fix this issue on am33.

Thanks for pointing this out, I once considered to use min_t() to do explicitly casting.
However, both values to compare are already size_t, maybe this depending on the compiler's
result of what sizeof() would be...


Cheers,
-Jeff

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>