Re: [PATCH] Revert "writeback: do not sync data dirtied after sync start"
From: Jan Kara <jack@suse.cz>
Date: 2014-02-22 01:04:36
Also in:
linux-fsdevel
On Fri 21-02-14 11:57:42, Andrew Morton wrote:
On Fri, 21 Feb 2014 11:30:01 +0100 Jan Kara [off-list ref] wrote:quoted
This reverts commit c4a391b53a72d2df4ee97f96f78c1d5971b47489. Dave Chinner [off-list ref] has reported the commit may cause some inodes to be left out from sync(2). This is because we can call redirty_tail() for some inode (which sets i_dirtied_when to current time) after sync(2) has started or similarly requeue_inode() can set i_dirtied_when to current time if writeback had to skip some pages. The real problem is in the functions clobbering i_dirtied_when but fixing that isn't trivial so revert is a safer choice for now. Signed-off-by: Jan Kara <jack@suse.cz>No cc:stable? The patch is applicable to 3.13.x.
Ah, forgot about it. Thanks for the reminder! Honza -- Jan Kara [off-list ref] SUSE Labs, CR -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>