Re: [PATCH] memcg: remove redundant code in mem_cgroup_force_empty_write()
From: Michal Hocko <hidden>
Date: 2013-07-25 08:02:17
Also in:
cgroups, lkml
On Thu 25-07-13 09:53:09, Li Zefan wrote:
vfs guarantees the cgroup won't be destroyed, so it's redundant to get a css reference. Signed-off-by: Li Zefan <redacted>
Acked-by: Michal Hocko <redacted> Thanks!
quoted hunk ↗ jump to hunk
--- mm/memcontrol.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-)diff --git a/mm/memcontrol.c b/mm/memcontrol.c index 03c8bf7..aa3e478 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c@@ -5015,15 +5015,10 @@ static int mem_cgroup_force_empty(struct mem_cgroup *memcg) static int mem_cgroup_force_empty_write(struct cgroup *cont, unsigned int event) { struct mem_cgroup *memcg = mem_cgroup_from_cont(cont); - int ret; if (mem_cgroup_is_root(memcg)) return -EINVAL; - css_get(&memcg->css); - ret = mem_cgroup_force_empty(memcg); - css_put(&memcg->css); - - return ret; + return mem_cgroup_force_empty(memcg); }-- 1.8.0.2
-- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>