Thread (10 messages) 10 messages, 4 authors, 2013-01-03

Re: [PATCH v2 2/3] mm: Update file times when inodes are written after mmaped writes

From: Andy Lutomirski <luto@amacapital.net>
Date: 2012-12-22 08:43:30
Also in: linux-fsdevel, lkml

On Sat, Dec 22, 2012 at 12:29 AM, Christoph Hellwig [off-list ref] wrote:
NAK, we went through great trouble to get rid of the nasty layering
violation where the VM called file_update_time directly just a short
while ago, reintroducing that is a massive step back.

Make sure whatever "solution" for your problem you come up with keeps
the file update in the filesystem or generic helpers.
There's an inode operation ->update_time that is called (if it exists)
in these patches to update the time.  Is that insufficient?  I could
add a new inode operation ->modified_by_mmap that would be called in
mapping_flush_cmtime if that would be better.

The original version of this patch did the update in ->writepage and
->writepages, but that may have had lock ordering issues.  (I wasn't
able to confirm that there was any actual problem.)

--Andy

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help