Re: [PATCH 2/2] mm: Generate events when tasks change their memory

[RFC PATCH 0/2] mm: Add ability to monitor task's memory changes · Pavel Emelyanov <hidden> · 2012-11-30
[PATCH 1/2] mm: Mark VMA with VM_TRACE bit · Pavel Emelyanov <hidden> · 2012-11-30
[PATCH 2/2] mm: Generate events when tasks change their memory · Pavel Emelyanov <hidden> · 2012-11-30
Re: [PATCH 2/2] mm: Generate events when tasks change their memory · Xiao Guangrong <hidden> · 2012-12-03
Re: [PATCH 2/2] mm: Generate events when tasks change their memory · Pavel Emelyanov <hidden> · 2012-12-04
Re: [RFC PATCH 0/2] mm: Add ability to monitor task's memory changes · Glauber Costa <hidden> · 2012-12-03
Re: [RFC PATCH 0/2] mm: Add ability to monitor task's memory changes · Marcelo Tosatti <hidden> · 2012-12-03
Re: [RFC PATCH 0/2] mm: Add ability to monitor task's memory changes · Glauber Costa <hidden> · 2012-12-04
Re: [RFC PATCH 0/2] mm: Add ability to monitor task's memory changes · Andrew Morton <akpm@linux-foundation.org> · 2012-12-03
Re: [RFC PATCH 0/2] mm: Add ability to monitor task's memory changes · Pavel Emelyanov <hidden> · 2012-12-04
Re: [RFC PATCH 0/2] mm: Add ability to monitor task's memory changes · Andrew Morton <akpm@linux-foundation.org> · 2012-12-04
Re: [RFC PATCH 0/2] mm: Add ability to monitor task's memory changes · Matt Mackall <hidden> · 2012-12-05
Re: [RFC PATCH 0/2] mm: Add ability to monitor task's memory changes · Andrew Morton <akpm@linux-foundation.org> · 2012-12-05
Re: [RFC PATCH 0/2] mm: Add ability to monitor task's memory changes · Matt Mackall <hidden> · 2012-12-05
Re: [RFC PATCH 0/2] mm: Add ability to monitor task's memory changes · Pavel Emelyanov <hidden> · 2012-12-05
Re: [RFC PATCH 0/2] mm: Add ability to monitor task's memory changes · Andrew Morton <akpm@linux-foundation.org> · 2012-12-05
Re: [RFC PATCH 0/2] mm: Add ability to monitor task's memory changes · Pavel Emelyanov <hidden> · 2012-12-06

From: Pavel Emelyanov <hidden>
Date: 2012-12-04 05:05:42

On 12/04/2012 03:42 AM, Xiao Guangrong wrote:

On 12/01/2012 01:55 AM, Pavel Emelyanov wrote:

quoted

 	case MADV_DOTRACE:
+		/*
+		 * Protect pages to be read-only and force tasks to generate
+		 * #PFs on modification.
+		 *
+		 * It should be done before issuing trace-on event. Otherwise
+		 * we're leaving a short window after the 'on' event when tasks
+		 * can still modify pages.
+		 */
+		change_protection(vma, start, end,
+				vm_get_page_prot(vma->vm_flags & ~VM_READ),
+				vma_wants_writenotify(vma));

Should be VM_WRITE?

Ooops! Yes, sure. I guess I accidentally broke it while cleaning/splitting patch :(

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help