Re: [PATCH 06/13] cpuset: cleanup cpuset[_can]_attach()
From: Tejun Heo <tj@kernel.org>
Date: 2012-12-26 12:04:21
Also in:
cgroups, lkml
From: Tejun Heo <tj@kernel.org>
Date: 2012-12-26 12:04:21
Also in:
cgroups, lkml
(cc'ing Rusty, hi!) Hello, Li. On Wed, Dec 26, 2012 at 06:20:11PM +0800, Li Zefan wrote:
On 2012/11/29 5:34, Tejun Heo wrote:quoted
cpuset_can_attach() prepare global variables cpus_attach and cpuset_attach_nodemask_{to|from} which are used by cpuset_attach(). There is no reason to prepare in cpuset_can_attach(). The same information can be accessed from cpuset_attach(). Move the prepartion logic from cpuset_can_attach() to cpuset_attach() and make the global variables static ones inside cpuset_attach(). While at it, convert cpus_attach to cpumask_t from cpumask_var_t. There's no reason to mess with dynamic allocation on a static buffer.But Rusty had been deprecating the use of cpumask_t. I don't know why the final deprecation hasn't been completed yet.
Hmmm? cpumask_t can't be used for stack but other than that I don't see how it would be deprecated completely. Rusty, can you please chime in? Thanks. -- tejun -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>