Re: [PATCH] mm/sparse: don't check return value of alloc_bootmem calls
From: David Rientjes <rientjes@google.com>
Date: 2012-12-20 20:30:12
Also in:
lkml
On Thu, 20 Dec 2012, Sasha Levin wrote:
quoted hunk ↗ jump to hunk
diff --git a/mm/sparse.c b/mm/sparse.c index 6b5fb76..ae64d6e 100644 --- a/mm/sparse.c +++ b/mm/sparse.c@@ -403,15 +403,13 @@ void __init sparse_mem_maps_populate_node(struct page **map_map, size = PAGE_ALIGN(size); map = __alloc_bootmem_node_high(NODE_DATA(nodeid), size * map_count, PAGE_SIZE, __pa(MAX_DMA_ADDRESS)); - if (map) { - for (pnum = pnum_begin; pnum < pnum_end; pnum++) { - if (!present_section_nr(pnum)) - continue; - map_map[pnum] = map; - map += size; - } - return; + for (pnum = pnum_begin; pnum < pnum_end; pnum++) { + if (!present_section_nr(pnum)) + continue; + map_map[pnum] = map; + map += size; } + return; /* fallback */ for (pnum = pnum_begin; pnum < pnum_end; pnum++) {
That's not true when slab_is_available() and why would you possibly add a return statement right before fallback code in such cases? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>