Re: [PATCH] mm: compare MIGRATE_ISOLATE selectively
From: Michal Nazarewicz <hidden>
Date: 2012-12-20 15:57:57
Also in:
lkml
On Thu, Dec 20 2012, Minchan Kim wrote:
quoted hunk ↗ jump to hunk
diff --git a/include/linux/page-isolation.h b/include/linux/page-isolation.h index a92061e..4ada4ef 100644 --- a/include/linux/page-isolation.h +++ b/include/linux/page-isolation.h@@ -1,6 +1,25 @@ #ifndef __LINUX_PAGEISOLATION_H #define __LINUX_PAGEISOLATION_H +#ifdef CONFIG_MEMORY_ISOLATION +static inline bool page_isolated_pageblock(struct page *page) +{ + return get_pageblock_migratetype(page) == MIGRATE_ISOLATE; +} +static inline bool mt_isolated_pageblock(int migratetype) +{ + return migratetype == MIGRATE_ISOLATE; +}
Perhaps “is_migrate_isolate” to match already existing “is_migrate_cma”? Especially as the “mt_isolated_pageblock” sound confusing to me, it implies that it works on pageblocks which it does not.
+#else
+static inline bool page_isolated_pageblock(struct page *page)
+{
+ return false;
+}
+static inline bool mt_isolated_pageblock(int migratetype)
+{
+ return false;
+}
+#endif
bool has_unmovable_pages(struct zone *zone, struct page *page, int count,
bool skip_hwpoisoned_pages);-- Best regards, _ _ .o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o ..o | Computer Science, Michał “mina86” Nazarewicz (o o) ooo +----<email/xmpp: mpn@google.com>--------------ooO--(_)--Ooo--