Thread (39 messages) 39 messages, 6 authors, 2012-12-05

Re: [PATCH 2/2, v2] mm/migration: Make rmap_walk_anon() and try_to_unmap_anon() more scalable

From: Rik van Riel <hidden>
Date: 2012-12-02 17:54:35
Also in: lkml

On 12/02/2012 10:12 AM, Ingo Molnar wrote:
Rename anon_vma_[un]lock() => anon_vma_[un]lock_write(),
to make it clearer that it's an exclusive write-lock in
that case - suggested by Rik van Riel.
... close, but you forgot to actually rename the unlock function :)
quoted hunk ↗ jump to hunk
diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h
index 7f5a552..81a9dee 100644
--- a/include/linux/huge_mm.h
+++ b/include/linux/huge_mm.h
@@ -101,7 +101,7 @@ extern void __split_huge_page_pmd(struct mm_struct *mm, pmd_t *pmd);
  #define wait_split_huge_page(__anon_vma, __pmd)				\
  	do {								\
  		pmd_t *____pmd = (__pmd);				\
-		anon_vma_lock(__anon_vma);				\
+		anon_vma_lock_write(__anon_vma);			\
  		anon_vma_unlock(__anon_vma);				\
  		BUG_ON(pmd_trans_splitting(*____pmd) ||			\
-- 
All rights reversed

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help