Re: [PATCH 2/5] mm, highmem: remove useless pool_lock
From: Minchan Kim <minchan@kernel.org>
Date: 2012-10-29 01:47:16
Also in:
lkml
On Mon, Oct 29, 2012 at 04:12:53AM +0900, Joonsoo Kim wrote:
The pool_lock protects the page_address_pool from concurrent access. But, access to the page_address_pool is already protected by kmap_lock. So remove it. Signed-off-by: Joonsoo Kim <redacted>
Reviewed-by: Minchan Kin <minchan@kernel.org> Looks good to me. Just a nitpick. Please write comment about locking rule like below.
quoted hunk ↗ jump to hunk
diff --git a/mm/highmem.c b/mm/highmem.c index b3b3d68..017bad1 100644 --- a/mm/highmem.c +++ b/mm/highmem.c@@ -328,7 +328,6 @@ struct page_address_map { * page_address_map freelist, allocated from page_address_maps. */
/* page_address_pool is protected by kmap_lock */
static struct list_head page_address_pool; /* freelist */ -static spinlock_t pool_lock; /* protects page_address_pool */
-- Kind regards, Minchan Kim -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>