Re: [PATCH 1/5] mm: compaction: Move migration fail/success stats to migrate.c
From: David Rientjes <rientjes@google.com>
Date: 2012-10-25 02:57:13
Also in:
lkml
From: David Rientjes <rientjes@google.com>
Date: 2012-10-25 02:57:13
Also in:
lkml
On Mon, 22 Oct 2012, Mel Gorman wrote:
The compact_pages_moved and compact_pagemigrate_failed events are convenient for determining if compaction is active and to what degree migration is succeeding but it's at the wrong level. Other users of migration may also want to know if migration is working properly and this will be particularly true for any automated NUMA migration. This patch moves the counters down to migration with the new events called pgmigrate_success and pgmigrate_fail. The compact_blocks_moved counter is removed because while it was useful for debugging initially, it's worthless now as no meaningful conclusions can be drawn from its value.
Agreed, "compact_blocks_moved" should have been named "compact_blocks_scanned" to accurately describe what it was representing.
Signed-off-by: Mel Gorman <mgorman@suse.de>
Acked-by: David Rientjes <rientjes@google.com> -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>