Thread (3 messages) 3 messages, 2 authors, 2012-09-28

Re: CK1 [07/13] slab: Use common kmalloc_index/kmalloc_size functions

From: Christoph Lameter <hidden>
Date: 2012-09-28 14:20:14

On Fri, 28 Sep 2012, Glauber Costa wrote:
One nitpick:
quoted
@@ -185,26 +169,19 @@ static __always_inline void *kmalloc_nod
 	struct kmem_cache *cachep;

 	if (__builtin_constant_p(size)) {
-		int i = 0;
+		int i;
Although this is technically correct, the former is correct as well, and
this end up only adding churn to the patch.
What does the "former" refer to?
Should you decide to remove it, there is another instance of this a bit
more down.
Remove what?

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help