On Tue, 25 Sep 2012, Ezequiel Garcia wrote:

The bug was introduced in commit 4052147c0afa
"mm, slab: Match SLAB and SLUB kmem_cache_alloc_xxx_trace() prototype".

This isn't a candidate for kernel-janitors@vger.kernel.org, these are 
patches that are one of Pekka's branches and would never make it to Linus' 
tree in this form.

Cc: Pekka Enberg <penberg@kernel.org>
Reported-by: Fengguang Wu <redacted>
Signed-off-by: Ezequiel Garcia <redacted>

Acked-by: David Rientjes <rientjes@google.com>

So now we have this for SLAB:

extern void *kmem_cache_alloc_node_trace(size_t size,
					 struct kmem_cache *cachep,
					 gfp_t flags,
					 int nodeid);

and this for SLUB:

extern void *kmem_cache_alloc_node_trace(struct kmem_cache *s,
					 gfp_t gfpflags,
					 int node, size_t size);

Would you like to send a follow-up patch to make these the same?  (My 
opinion is that the SLUB variant is the correct order.)

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>