Thread (1 message) 1 message, 1 author, 2012-09-04

C14 [01/14] [PATCH 10/28] slub: Add debugging to verify correct cache use on kmem_cache_free()

From: Christoph Lameter <hidden>
Date: 2012-09-04 23:06:16

Add additional debugging to check that the objects is actually from the cache
the caller claims. Doing so currently trips up some other debugging code. It
takes a lot to infer from that what was happening.

V2: Only warn once.

Reviewed-by: Glauber Costa <redacted>
Signed-off-by: Christoph Lameter <redacted>
---
 mm/slub.c |    7 +++++++
 1 file changed, 7 insertions(+)

Index: linux/mm/slub.c
===================================================================
--- linux.orig/mm/slub.c	2012-09-04 18:00:13.218025791 -0500
+++ linux/mm/slub.c	2012-09-04 18:02:00.947707104 -0500
@@ -2614,6 +2614,13 @@ void kmem_cache_free(struct kmem_cache *
 
 	page = virt_to_head_page(x);
 
+	if (kmem_cache_debug(s) && page->slab != s) {
+		printk("kmem_cache_free: Wrong slab cache. %s but object"
+			" is from  %s\n", page->slab->name, s->name);
+		WARN_ON_ONCE(1);
+		return;
+	}
+
 	slab_free(s, page, x, _RET_IP_);
 
 	trace_kmem_cache_free(_RET_IP_, x);

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help