Hi Kosaki-san,

2012/09/28 10:13, KOSAKI Motohiro wrote:

On Thu, Sep 27, 2012 at 8:07 PM, Yasuaki Ishimatsu
[off-list ref] wrote:

quoted

Hi Kosaki-san,


2012/09/28 5:13, KOSAKI Motohiro wrote:

quoted

On Thu, Sep 27, 2012 at 1:45 AM,  [off-list ref] wrote:

quoted

From: Yasuaki Ishimatsu <redacted>

When calling unregister_node(), the function shows following message at
device_release().

This description doesn't have the "following message".

quoted

quoted

Device 'node2' does not have a release() function, it is broken and must
be
fixed.

This is the messages. The message is shown by kobject_cleanup(), when
calling
unregister_node().

If so, you should quote the message. and don't mix it with your
subject. Moreover
your patch title is too silly. "add node_device_release() function" is
a way. you should
describe the effect of the patch. e.g. suppress "Device 'nodeXX' does
not have a release() function" warning.

What you say is correct. We should update subject and changelog.

Moreover, your explanation is still insufficient. Even if
node_device_release() is empty function, we can get rid of the
warning.

I don't understand it. How can we get rid of the warning?

Why do we need this node_device_release() implementation?

I think that this is a manner of releasing object related kobject.

Thanks,
Yasuaki Ishimatsu




--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>