Re: [PATCH 3/3] zram: select ZSMALLOC when ZRAM is configured
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: 2012-09-26 16:15:46
Also in:
lkml
On Wed, Sep 26, 2012 at 05:50:19PM +0900, Minchan Kim wrote:
quoted hunk ↗ jump to hunk
At the monent, we can configure zram in driver/block once zsmalloc in /lib menu is configured firstly. It's not convenient. User can configure zram in driver/block regardless of zsmalloc enabling by this patch. Signed-off-by: Minchan Kim <minchan@kernel.org> --- drivers/block/zram/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)diff --git a/drivers/block/zram/Kconfig b/drivers/block/zram/Kconfig index be5abe8..ee23a86 100644 --- a/drivers/block/zram/Kconfig +++ b/drivers/block/zram/Kconfig@@ -1,6 +1,7 @@ config ZRAM tristate "Compressed RAM block device support" - depends on BLOCK && SYSFS && ZSMALLOC + depends on BLOCK && SYSFS + select ZSMALLOC
As ZSMALLOC is dependant on CONFIG_STAGING, this isn't going to work at all, sorry. If your code depends on staging code, we need to get the staging code out of staging first, before this code can be moved out. So please work to get zsmalloc cleaned up and merged out first please, as it is, this patch series is not ok. greg k-h -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>