Thread (12 messages) 12 messages, 4 authors, 2012-09-26

Re: [PATCH] pagemap: fix wrong KPF_THP on slab pages

From: David Rientjes <rientjes@google.com>
Date: 2012-09-26 00:21:19
Also in: lkml

On Tue, 25 Sep 2012, Naoya Horiguchi wrote:
KPF_THP can be set on non-huge compound pages like slab pages, because
PageTransCompound only sees PG_head and PG_tail. Obviously this is a bug
and breaks user space applications which look for thp via /proc/kpageflags.
Currently thp is constructed only on anonymous pages, so this patch makes
KPF_THP be set when both of PageAnon and PageTransCompound are true.

Changelog in v2:
  - add a comment in code

Signed-off-by: Naoya Horiguchi <redacted>
Wouldn't PageTransCompound(page) && !PageHuge(page) && !PageSlab(page) be 
better for a future extension of thp support?

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help