Re: [PATCH 4/9] mm: compaction: Abort compaction loop if lock is contended... | linux-mm

[PATCH 0/9] Reduce compaction scanning and lock contention · Mel Gorman <mgorman@suse.de> · 2012-09-21
[PATCH 1/9] Revert "mm: compaction: check lock contention first before taking lock" · Mel Gorman <mgorman@suse.de> · 2012-09-21
Re: [PATCH 1/9] Revert "mm: compaction: check lock contention first before taking lock" · Rafael Aquini <hidden> · 2012-09-21
[PATCH 3/9] Revert "mm: compaction: abort compaction loop if lock is contended or run too long" · Mel Gorman <mgorman@suse.de> · 2012-09-21
Re: [PATCH 3/9] Revert "mm: compaction: abort compaction loop if lock is contended or run too long" · Rafael Aquini <hidden> · 2012-09-21
[PATCH 5/9] mm: compaction: Acquire the zone->lru_lock as late as possible · Mel Gorman <mgorman@suse.de> · 2012-09-21
Re: [PATCH 5/9] mm: compaction: Acquire the zone->lru_lock as late as possible · Rafael Aquini <hidden> · 2012-09-21
Re: [PATCH 5/9] mm: compaction: Acquire the zone->lru_lock as late as possible · Minchan Kim <minchan@kernel.org> · 2012-09-25
Re: [PATCH 5/9] mm: compaction: Acquire the zone->lru_lock as late as possible · Mel Gorman <mgorman@suse.de> · 2012-09-25
Re: [PATCH 5/9] mm: compaction: Acquire the zone->lru_lock as late as possible · Minchan Kim <minchan@kernel.org> · 2012-09-25
Re: [PATCH 5/9] mm: compaction: Acquire the zone->lru_lock as late as possible · Andrew Morton <akpm@linux-foundation.org> · 2012-09-25
Re: [PATCH 5/9] mm: compaction: Acquire the zone->lru_lock as late as possible · Minchan Kim <minchan@kernel.org> · 2012-09-26
Re: [PATCH 5/9] mm: compaction: Acquire the zone->lru_lock as late as possible · Mel Gorman <mgorman@suse.de> · 2012-09-26
[PATCH 4/9] mm: compaction: Abort compaction loop if lock is contended or run too long · Mel Gorman <mgorman@suse.de> · 2012-09-21
Re: [PATCH 4/9] mm: compaction: Abort compaction loop if lock is contended or run too long · Rafael Aquini <hidden> · 2012-09-21
Re: [PATCH 4/9] mm: compaction: Abort compaction loop if lock is contended or run too long · Andrew Morton <akpm@linux-foundation.org> · 2012-09-21
Re: [PATCH 4/9] mm: compaction: Abort compaction loop if lock is contended or run too long · Minchan Kim <minchan@kernel.org> · 2012-09-25
[PATCH 7/9] Revert "mm: have order > 0 compaction start off where it left" · Mel Gorman <mgorman@suse.de> · 2012-09-21
Re: [PATCH 7/9] Revert "mm: have order > 0 compaction start off where it left" · Rafael Aquini <hidden> · 2012-09-21
Re: [PATCH 7/9] Revert "mm: have order > 0 compaction start off where it left" · Minchan Kim <minchan@kernel.org> · 2012-09-25
[PATCH 6/9] mm: compaction: Acquire the zone->lock as late as possible · Mel Gorman <mgorman@suse.de> · 2012-09-21
Re: [PATCH 6/9] mm: compaction: Acquire the zone->lock as late as possible · Rafael Aquini <hidden> · 2012-09-21
Re: [PATCH 6/9] mm: compaction: Acquire the zone->lock as late as possible · Andrew Morton <akpm@linux-foundation.org> · 2012-09-21
Re: [PATCH 6/9] mm: compaction: Acquire the zone->lock as late as possible · Mel Gorman <mgorman@suse.de> · 2012-09-24
Re: [PATCH 6/9] mm: compaction: Acquire the zone->lock as late as possible · Minchan Kim <minchan@kernel.org> · 2012-09-25
Re: [PATCH 6/9] mm: compaction: Acquire the zone->lock as late as possible · Minchan Kim <minchan@kernel.org> · 2012-09-25
[PATCH 9/9] mm: compaction: Restart compaction from near where it left off · Mel Gorman <mgorman@suse.de> · 2012-09-21
Re: [PATCH 9/9] mm: compaction: Restart compaction from near where it left off · Rafael Aquini <hidden> · 2012-09-21
[PATCH 8/9] mm: compaction: Cache if a pageblock was scanned and no pages were isolated · Mel Gorman <mgorman@suse.de> · 2012-09-21
Re: [PATCH 8/9] mm: compaction: Cache if a pageblock was scanned and no pages were isolated · Rafael Aquini <hidden> · 2012-09-21
Re: [PATCH 8/9] mm: compaction: Cache if a pageblock was scanned and no pages were isolated · Andrew Morton <akpm@linux-foundation.org> · 2012-09-21
Re: [PATCH 8/9] mm: compaction: Cache if a pageblock was scanned and no pages were isolated · Mel Gorman <mgorman@suse.de> · 2012-09-24
Re: [PATCH 8/9] mm: compaction: Cache if a pageblock was scanned and no pages were isolated · Andrew Morton <akpm@linux-foundation.org> · 2012-09-24
Re: [PATCH 8/9] mm: compaction: Cache if a pageblock was scanned and no pages were isolated · Mel Gorman <mgorman@suse.de> · 2012-09-25
Re: [PATCH 8/9] mm: compaction: Cache if a pageblock was scanned and no pages were isolated · Andrew Morton <akpm@linux-foundation.org> · 2012-09-25
[PATCH] mm: compaction: cache if a pageblock was scanned and no pages were isolated -fix2 · Mel Gorman <mgorman@suse.de> · 2012-09-27
Re: [PATCH 8/9] mm: compaction: Cache if a pageblock was scanned and no pages were isolated · Mel Gorman <mgorman@suse.de> · 2012-09-27
Re: [PATCH 8/9] mm: compaction: Cache if a pageblock was scanned and no pages were isolated · Minchan Kim <minchan@kernel.org> · 2012-09-26
Re: [PATCH 8/9] mm: compaction: Cache if a pageblock was scanned and no pages were isolated · Mel Gorman <mgorman@suse.de> · 2012-09-27
[PATCH 2/9] Revert "mm-compaction-abort-compaction-loop-if-lock-is-contended-or-run-too-long-fix" · Mel Gorman <mgorman@suse.de> · 2012-09-21
Re: [PATCH 2/9] Revert "mm-compaction-abort-compaction-loop-if-lock-is-contended-or-run-too-long-fix" · Rafael Aquini <hidden> · 2012-09-21
Re: [PATCH 0/9] Reduce compaction scanning and lock contention · Rik van Riel <hidden> · 2012-09-21

Re: [PATCH 4/9] mm: compaction: Abort compaction loop if lock is contended or run too long

From: Rafael Aquini <hidden>
Date: 2012-09-21 17:50:45
Also in: kvm, lkml, qemu-devel

On Fri, Sep 21, 2012 at 11:46:18AM +0100, Mel Gorman wrote:

From: Shaohua Li <redacted>

Changelog since V2
o Fix BUG_ON triggered due to pages left on cc.migratepages
o Make compact_zone_order() require non-NULL arg `contended'

Changelog since V1
o only abort the compaction if lock is contended or run too long
o Rearranged the code by Andrea Arcangeli.

isolate_migratepages_range() might isolate no pages if for example when
zone->lru_lock is contended and running asynchronous compaction. In this
case, we should abort compaction, otherwise, compact_zone will run a
useless loop and make zone->lru_lock is even contended.

[minchan@kernel.org: Putback pages isolated for migration if aborting]
[akpm@linux-foundation.org: compact_zone_order requires non-NULL arg contended]
Signed-off-by: Andrea Arcangeli <redacted>
Signed-off-by: Shaohua Li <redacted>
Signed-off-by: Mel Gorman <mgorman@suse.de>
Acked-by: Rik van Riel <redacted>
---

Acked-by: Rafael Aquini <redacted>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help