Re: [PATCH v3 08/16] slab: allow enable_cpu_cache to use preset values for its tunables
From: Pekka Enberg <penberg@kernel.org>
Date: 2012-09-21 09:29:24
Also in:
cgroups, lkml
On Tue, Sep 18, 2012 at 5:12 PM, Glauber Costa [off-list ref] wrote:
quoted hunk ↗ jump to hunk
diff --git a/mm/slab.c b/mm/slab.c index e2cf984..f2d760c 100644 --- a/mm/slab.c +++ b/mm/slab.c@@ -4141,8 +4141,19 @@ static int do_tune_cpucache(struct kmem_cache *cachep, int limit, static int enable_cpucache(struct kmem_cache *cachep, gfp_t gfp) { int err; - int limit, shared; - + int limit = 0; + int shared = 0; + int batchcount = 0; + +#ifdef CONFIG_MEMCG_KMEM + if (cachep->memcg_params.parent) { + limit = cachep->memcg_params.parent->limit; + shared = cachep->memcg_params.parent->shared; + batchcount = cachep->memcg_params.parent->batchcount;
Style nit: please introduce a variable for "cachep->memcg_params.parent" to make this human-readable. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>