Re: mm: frontswap: fix a wrong if condition in frontswap_shrink
From: Dan Carpenter <hidden>
Date: 2012-09-21 07:24:09
Also in:
lkml
From: Dan Carpenter <hidden>
Date: 2012-09-21 07:24:09
Also in:
lkml
On Fri, Sep 21, 2012 at 11:29:56AM +0800, Zhenzhong Duan wrote:
pages_to_unuse is set to 0 to unuse all frontswap pages But that doesn't happen since a wrong condition in frontswap_shrink cancels it. Signed-off-by: Zhenzhong Duan <redacted> --- mm/frontswap.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)diff --git a/mm/frontswap.c b/mm/frontswap.c index 6b3e71a..db2a86f 100644 --- a/mm/frontswap.c +++ b/mm/frontswap.c@@ -275,7 +275,7 @@ static int __frontswap_shrink(unsigned long target_pages, if (total_pages <= target_pages) { /* Nothing to do */ *pages_to_unuse = 0; - return 0; + return 1; }
This function used to return 0 or an error code. Could we add a comment at the top saying what the return values mean. regards, dan carpenter -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>