Re: [PATCH v2 07/12] rbtree: adjust root color in rb_insert_color() only when necessary
From: Michel Lespinasse <hidden>
Date: 2012-08-31 08:39:51
Also in:
lkml
On Fri, Aug 31, 2012 at 1:35 AM, Adrian Hunter [off-list ref] wrote:
quoted hunk ↗ jump to hunk
On 31/08/12 11:15, Andrew Morton wrote:quoted
On Fri, 31 Aug 2012 01:07:24 -0700 Michel Lespinasse [off-list ref] wrote:quoted
I thought Andrew had a patch rbtree-adjust-root-color-in-rb_insert_color-only-when-necessary-fix-perf-compilation that fixed this though a Makefile change ?Yup. But it's unclear why we should include the header via the cc command line?Dunno AFAICS tools/perf/util/include/linux is for fixing up the differences between kernel headers and exported kernel headers. Hence my change:diff --git a/tools/perf/util/include/linux/rbtree.h b/tools/perf/util/include/linux/rbtree.h index 7a243a1..2a030c5 100644 --- a/tools/perf/util/include/linux/rbtree.h +++ b/tools/perf/util/include/linux/rbtree.h@@ -1 +1,2 @@ +#include <stdbool.h> #include "../../../../include/linux/rbtree.h"Alex?
Ah, makes sense to me. I wasn't previously aware of the tools/perf/util/include/linux directory. I think your fix is fine. (I don't understand how you hit the issue given the previous Makefile fix, but I think your fix looks nicer) -- Michel "Walken" Lespinasse A program is never fully debugged until the last user dies. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>