Re: Fixup the page of buddy_higher address's calculation
From: Michal Hocko <hidden>
Date: 2012-08-24 08:06:37
Also in:
lkml
On Fri 24-08-12 10:08:20, Li Haifeng wrote: [...]
Subject: [PATCH] Fix the page address of higher page's buddy calculation Calculate the page address of higher page's buddy should be based higher_page with the offset between index of higher page and index of higher page's buddy.
Sorry for insisting but could you add an information about when this has been introduced (I have mentioned the commit in the other email) and the effect of the bug so that we can consider whether this is worth backporting to stable trees.
Signed-off-by: Haifeng Li <redacted> Signed-off-by: Gavin Shan <redacted>
Other than that Reviewed-by: Michal Hocko <redacted>
quoted hunk ↗ jump to hunk
--- mm/page_alloc.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)diff --git a/mm/page_alloc.c b/mm/page_alloc.c index cdef1d4..642cd62 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c@@ -536,7 +536,7 @@ static inline void __free_one_page(struct page *page, combined_idx = buddy_idx & page_idx; higher_page = page + (combined_idx - page_idx); buddy_idx = __find_buddy_index(combined_idx, order + 1); - higher_buddy = page + (buddy_idx - combined_idx); + higher_buddy = higher_page + (buddy_idx - combined_idx); if (page_is_buddy(higher_page, higher_buddy, order + 1)) { list_add_tail(&page->lru, &zone->free_area[order].free_list[migratetype]); --1.7.5.4
-- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>