Re: [PATCH 2/3] kmemleak: replace list_for_each_continue_rcu with new interface
From: Michael Wang <hidden>
Date: 2012-08-24 00:53:05
Also in:
lkml
On 08/17/2012 12:33 PM, Michael Wang wrote:
From: Michael Wang <redacted> This patch replaces list_for_each_continue_rcu() with list_for_each_entry_continue_rcu() to save a few lines of code and allow removing list_for_each_continue_rcu().
Hi, Catalin Could I get some comments on this patch? Regards, Michael Wang
quoted hunk ↗ jump to hunk
Signed-off-by: Michael Wang <redacted> --- mm/kmemleak.c | 6 ++---- 1 files changed, 2 insertions(+), 4 deletions(-)diff --git a/mm/kmemleak.c b/mm/kmemleak.c index 45eb621..0de83b4 100644 --- a/mm/kmemleak.c +++ b/mm/kmemleak.c@@ -1483,13 +1483,11 @@ static void *kmemleak_seq_next(struct seq_file *seq, void *v, loff_t *pos) { struct kmemleak_object *prev_obj = v; struct kmemleak_object *next_obj = NULL; - struct list_head *n = &prev_obj->object_list; + struct kmemleak_object *obj = prev_obj; ++(*pos); - list_for_each_continue_rcu(n, &object_list) { - struct kmemleak_object *obj = - list_entry(n, struct kmemleak_object, object_list); + list_for_each_entry_continue_rcu(obj, &object_list, object_list) { if (get_object(obj)) { next_obj = obj; break;
-- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>