Thread (23 messages) 23 messages, 5 authors, 2012-08-16

Re: [PATCH] mm: hugetlb: flush dcache before returning zeroed huge page to userspace

From: Will Deacon <hidden>
Date: 2012-08-16 18:33:15
Also in: linux-arch, lkml

On Thu, Aug 16, 2012 at 07:20:15PM +0100, Michal Hocko wrote:
On Thu 16-08-12 17:09:54, Will Deacon wrote:
quoted
+static inline void arch_clear_hugepage_flags(struct page *page)
+{
+	flush_dcache_page(page);
+}
+
Why do we need the hook for ia64? hugetlb_no_page calls clear_huge_page
and that one calls flush_dcache_page (via clear_user_page), right?
The same applies to copy_huge_page for COW.
You're right, these are redundant for ppc and ia64 (although ppc does have a
comment moaning about the flush). Looks like it's just sh and ARM that need to
do anything.

Cheers,

Will

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help