Thread (21 messages) 21 messages, 4 authors, 2012-08-15

Re: [PATCH 01/16] hashtable: introduce a small and naive hashtable

From: Tejun Heo <tj@kernel.org>
Date: 2012-08-15 00:28:42
Also in: dm-devel, linux-nfs, lkml, netdev

Hello,

(Sasha, would it be possible to change your MUA so that it breaks long
 lines.  It's pretty difficult to reply to.)

On Wed, Aug 15, 2012 at 02:24:49AM +0200, Sasha Levin wrote:
The hashtable uses hlist. hlist provides us with an entire family of
init functions which I'm supposed to use to initialize hlist heads.

So while a memset(0) will work perfectly here, I consider that
cheating - it results in an uglier code that assumes to know about
hlist internals, and will probably break as soon as someone tries to
do something to hlist.
I think we should stick with INIT_HLIST_HEAD().  It's not a hot path
and we might add, say, debug fields or initialization magics added
later.  If this really matters, the right thing to do would be adding
something like INIT_HLIST_HEAD_ARRAY().

Thanks.

-- 
tejun

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help