On Mon, Aug 6, 2012 at 7:23 AM, Peter Zijlstra [off-list ref] wrote:

On Thu, 2012-08-02 at 15:34 -0700, Michel Lespinasse wrote:

quoted

+             tmp = gparent->rb_right;
+             if (parent != tmp) {    /* parent == gparent->rb_left */

quoted

+                     tmp = parent->rb_right;
+                     if (node == tmp) {

quoted

+                     tmp = parent->rb_left;
+                     if (node == tmp) {

quoted

+             sibling = parent->rb_right;
+             if (node != sibling) {  /* node == parent->rb_left */

Half of them got a comment, the other half didn't.. is there any
particular reason for that?

I felt that the equality tests didn't need explanation. But the tests
where I test for inequality with the supposed sibling didn't seem
quite so obvious to me, so I commented them.

-- 
Michel "Walken" Lespinasse
A program is never fully debugged until the last user dies.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>