Re: [PATCH v4 1/3] mm: introduce compaction and migration for virtio ballooned pages
From: Rafael Aquini <hidden>
Date: 2012-08-03 11:13:59
Also in:
lkml, virtualization
From: Rafael Aquini <hidden>
Date: 2012-08-03 11:13:59
Also in:
lkml, virtualization
On Wed, Aug 01, 2012 at 04:53:47PM -0400, Rik van Riel wrote:
On 07/23/2012 02:19 PM, Rafael Aquini wrote:quoted
In a glance, I believe this whole dance you're suggesting might just be too much of an overcomplication, and the best approach would be simply teaching the hotplug bits about the ballooned corner case just like it's being done to compaction/migration. However, I'll look at it carefully before making any other adjustments/propositions over here.Compaction and hotplug do essentially the same thing here: "collect all the movable pages from a page block, and move them elsewhere". Whether or not it is easier for them to share code, or to duplicate a few lines of code, is something that can be looked into later.
I'm 100% in agreement with your thoughts here. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>