Re: + memory-hotplug-fix-kswapd-looping-forever-problem-fix-fix.patch added to -mm tree
From: Andrew Morton <akpm@linux-foundation.org>
Date: 2012-07-18 21:38:11
From: Andrew Morton <akpm@linux-foundation.org>
Date: 2012-07-18 21:38:11
On Wed, 18 Jul 2012 10:22:00 +0900 Minchan Kim [off-list ref] wrote:
quoted
Is this really necessary? Does the zone start out all-zeroes? If not, can we make it do so?Good point. It can remove zap_zone_vm_stats and zone->flags = 0, too. More important thing is that we could remove adding code to initialize zero whenever we add new field to zone. So I look at the code. In summary, IMHO, all is already initialie zero out but we need double check in mips.
Well, this is hardly a performance-critical path. So rather than groveling around ensuring that each and every architectures does the right thing, would it not be better to put a single memset() into core MM if there is an appropriate place? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>