Re: [PATCH 1/2] Revert "hugetlb: avoid taking i_mmap_mutex in unmap_single_vma() for hugetlb"
From: Andrew Morton <akpm@linux-foundation.org>
Date: 2012-07-30 22:28:35
Also in:
lkml
From: Andrew Morton <akpm@linux-foundation.org>
Date: 2012-07-30 22:28:35
Also in:
lkml
On Fri, 27 Jul 2012 22:45:04 +0530 "Aneesh Kumar K.V" [off-list ref] wrote:
quoted
Unless Aneesh has another reason for the patch, it should be reverted to preserve hugetlb page sharing locking.I guess we want to take this patch as a revert patch rather than dropping the one in -mm. That would help in documenting the i_mmap_mutex locking details in commit message. Or may be we should add necessary comments around the locking ?
Code comments would be better if possible - we shouldn't force people to dig around in git history to understand small code snippets. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>