Re: [RESEND PATCH 2/4 v3] mm: fix possible incorrect return value of migrate_pages() syscall
From: JoonSoo Kim <hidden>
Date: 2012-07-28 06:16:30
Also in:
lkml
From: JoonSoo Kim <hidden>
Date: 2012-07-28 06:16:30
Also in:
lkml
2012/7/28 Christoph Lameter [off-list ref]:
On Sat, 28 Jul 2012, Joonsoo Kim wrote:quoted
do_migrate_pages() can return the number of pages not migrated. Because migrate_pages() syscall return this value directly, migrate_pages() syscall may return the number of pages not migrated. In fail case in migrate_pages() syscall, we should return error value. So change err to -EBUSYLets leave this alone. This would change the migrate_pages semantics because a successful move of N out of M pages would be marked as a total failure although pages were in fact moved.
Okay. Then, do we need to fix man-page of migrate_pages() syscall? According to man-page, only returning 0 or -1 is valid. Without this patch, it can return positive value. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>