Re: [PATCH 2/2 v5][resend] tmpfs: interleave the starting node of /dev/shmem

Yes I had failed to notice that.
I'll send a fix shortly.


On 07/23/2012 05:58 AM, Dan Carpenter wrote:

On Mon, Jul 09, 2012 at 09:46:39AM -0500, Nathan Zimmer wrote:

quoted

+static unsigned long shmem_interleave(struct vm_area_struct *vma,
+					unsigned long addr)
+{
+	unsigned long offset;
+
+	/* Use the vm_files prefered node as the initial offset. */
+	offset = (unsigned long *) vma->vm_private_data;

Should this be?:
	offset = (unsigned long)vma->vm_private_data;

offset is an unsigned long, not a pointer.  ->vm_private_data is a
void pointer.

It causes a GCC warning:
mm/shmem.c: In function a??shmem_interleavea??:
mm/shmem.c:1341:9: warning: assignment makes integer from pointer without a cast [enabled by default]

quoted

+
+	offset += ((addr - vma->vm_start) >> PAGE_SHIFT) + vma->vm_pgoff;
+
+	return offset;
+}
  #endif

regards,
dan carpenter

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>