Hi Hugh,

On Thu, May 31, 2012 at 03:31:27PM -0700, Hugh Dickins wrote:

* shmem_replace_page must flush_dcache_page after copy_highpage [akpm]

 
-	*pagep = newpage;
 	page_cache_get(newpage);
 	copy_highpage(newpage, oldpage);
+	flush_dcache_page(newpage);
 

Couldn't we use the lighter flush_kernel_dcache_page() here (like in
fs/exec.c copy_strings())?  If I got this correctly, the page is
copied via the kernel mapping and thus, only the kernel mapping needs
to be flushed.

- Simon

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>