Thread (3 messages) 3 messages, 2 authors, 2012-06-29

Re: [PATCH] vmscan: remove obsolete comment of shrinker

From: Cong Wang <hidden>
Date: 2012-06-29 13:16:00

On Fri, 29 Jun 2012 at 04:51 GMT, Minchan Kim [off-list ref] wrote:
09f363c7 fixed shrinker callback returns -1 when nr_to_scan is zero
for preventing excessive the slab scanning. But 635697c6 fixed the
problem, again so we can freely return -1 although nr_to_scan is zero.
So let's revert 09f363c7 because the comment added in 09f363c7 made a
unnecessary rule shrinker user should be aware of.
Please also include the subject of the commit, not just raw hash number. ;)

For example,

09f363c7("vmscan: fix shrinker callback bug in fs/super.c")
635697c6("vmscan: fix initial shrinker size handling")

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help