On Tue, Jun 26, 2012 at 07:31:21PM +0400, Glauber Costa wrote:

On 06/26/2012 06:11 PM, Johannes Weiner wrote:

quoted

I find the warning message a bit terse.  Maybe include something like
"restructure the cgroup directory structure to match your accounting
requirements or complain to (linux-mm, cgroups list etc.)  if not
possible"

How about:

WARN_ONCE(!parent_memcg && memcg->use_hierarchy,
   "Non-hierarchical memcg is considered for deprecation\n"
   "Please consider reorganizing your tree to work with hierarchical
accounting\n"
   "If you have any reason not to, let us know at
cgroups@vger.kernel.org\n");

Sounds good to me, thanks!

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>