Thread (26 messages) 26 messages, 4 authors, 2012-06-27

Re: [PATCH 3/5] mm/sparse: fix possible memory leak

From: Gavin Shan <hidden>
Date: 2012-06-26 07:17:28

quoted
quoted
quoted
With CONFIG_SPARSEMEM_EXTREME, the root memory section descriptors
are allocated by slab or bootmem allocator. Also, the descriptors
might have been allocated and initialized by others. However, the
memory chunk allocated in current implementation wouldn't be put
into the available pool if others have allocated memory chunk for
that.
Who is others? I assume that we can race in hotplug because other than
that this is an early initialization code. How can others race?
I'm sorry that I don't have the real bug against the issue. 
I am not saying the bug is not real. It is just that the changelog
doesn's say how the bug is hit, who is affected and when it has been
introduced. These is essential for stable.
Thanks, Michal. Let me replace "others" with "hotplug" in next revision :-)

Thanks,
Gavin
-- 
Michal Hocko
SUSE Labs
SUSE LINUX s.r.o.
Lihovarska 1060/12
190 00 Praha 9    
Czech Republic
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help