[PATCH V5 3/5] mm: memcg detect no memcgs above softlimit under zone reclaim
From: Ying Han <hidden>
Date: 2012-06-18 16:47:32
Subsystem:
memory management, memory management - mglru (multi-gen lru), memory management - reclaim, the rest · Maintainers:
Andrew Morton, Johannes Weiner, Linus Torvalds
In memcg kernel, cgroup under its softlimit is not targeted under global reclaim. It could be possible that all memcgs are under their softlimit for a particular zone. If that is the case, the current implementation will burn extra cpu cycles without making forward progress. The idea is from LSF discussion where we detect it after the first round of scanning and restart the reclaim by not looking at softlimit at all. This allows us to make forward progress on shrink_zone(). Signed-off-by: Ying Han <redacted> --- mm/vmscan.c | 17 +++++++++++++++-- 1 files changed, 15 insertions(+), 2 deletions(-)
diff --git a/mm/vmscan.c b/mm/vmscan.c
index 8c367e1..51f8cc9 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c@@ -1827,6 +1827,10 @@ static void shrink_zone(struct zone *zone, struct scan_control *sc) .priority = sc->priority, }; struct mem_cgroup *memcg; + bool over_softlimit, ignore_softlimit = false; + +restart: + over_softlimit = false; memcg = mem_cgroup_iter(root, NULL, &reclaim); do {
@@ -1845,10 +1849,14 @@ static void shrink_zone(struct zone *zone, struct scan_control *sc) * we have to reclaim under softlimit instead of burning more * cpu cycles. */ - if (!global_reclaim(sc) || sc->priority < DEF_PRIORITY - 2 || - should_reclaim_mem_cgroup(memcg)) + if (ignore_softlimit || !global_reclaim(sc) || + sc->priority < DEF_PRIORITY - 2 || + should_reclaim_mem_cgroup(memcg)) { shrink_lruvec(lruvec, sc); + over_softlimit = true; + } + /* * Limit reclaim has historically picked one memcg and * scanned it with decreasing priority levels until
@@ -1865,6 +1873,11 @@ static void shrink_zone(struct zone *zone, struct scan_control *sc) } memcg = mem_cgroup_iter(root, memcg, &reclaim); } while (memcg); + + if (!over_softlimit) { + ignore_softlimit = true; + goto restart; + } } /* Returns true if compaction should go ahead for a high-order request */
--
1.7.7.3
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>