Common [04/20] [slab] Use page struct fields instead of casting
From: Christoph Lameter <hidden>
Date: 2012-06-01 19:53:04
Add fields to the page struct so that it is properly documented that slab overlays the lru fields. This cleans up some casts in slab. Reviewed-by: Glauber Costa <redacted> Reviewed-by: Joonsoo Kim <redacted> Signed-off-by: Christoph Lameter <redacted> --- include/linux/mm_types.h | 4 ++++ mm/slab.c | 8 ++++---- 2 files changed, 8 insertions(+), 4 deletions(-) Index: linux-2.6/mm/slab.c ===================================================================
--- linux-2.6.orig/mm/slab.c 2012-06-01 02:57:10.719019693 -0500
+++ linux-2.6/mm/slab.c 2012-06-01 02:57:14.875019607 -0500@@ -496,25 +496,25 @@ static bool slab_max_order_set __initdat */ static inline void page_set_cache(struct page *page, struct kmem_cache *cache) { - page->lru.next = (struct list_head *)cache; + page->slab_cache = cache; } static inline struct kmem_cache *page_get_cache(struct page *page) { page = compound_head(page); BUG_ON(!PageSlab(page)); - return (struct kmem_cache *)page->lru.next; + return page->slab_cache; } static inline void page_set_slab(struct page *page, struct slab *slab) { - page->lru.prev = (struct list_head *)slab; + page->slab_page = slab; } static inline struct slab *page_get_slab(struct page *page) { BUG_ON(!PageSlab(page)); - return (struct slab *)page->lru.prev; + return page->slab_page; } static inline struct kmem_cache *virt_to_cache(const void *obj)
Index: linux-2.6/include/linux/mm_types.h ===================================================================
--- linux-2.6.orig/include/linux/mm_types.h 2012-06-01 02:57:12.735019652 -0500
+++ linux-2.6/include/linux/mm_types.h 2012-06-01 03:00:05.031016077 -0500@@ -110,6 +110,10 @@ struct page { }; struct list_head list; /* slobs list of pages */ + struct { /* slab fields */ + struct kmem_cache *slab_cache; + struct slab *slab_page; + }; }; /* Remainder is not double word aligned */ --
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>