Re: [PATCH 1/6] memcg: replace unsigned long by u64 to avoid overflow

On Sat, Jun 23, 2012 at 05:03:39PM +0800, Wanpeng Li wrote:

On Sat, Jun 23, 2012 at 10:15:14AM +0200, Johannes Weiner wrote:

quoted

On Sat, Jun 23, 2012 at 02:15:34PM +0800, Wanpeng Li wrote:

quoted

From: Wanpeng Li <redacted>

Since the return value variable in mem_cgroup_zone_nr_lru_pages and
mem_cgroup_node_nr_lru_pages functions are u64, so replace the return
value of funtions by u64 to avoid overflow.

I wonder what 16 TB of memory must think running on a 32-bit kernel...
"What is this, an address space for ants?"

Hi Johannes,

You mean change all u64 in memcg to unsigned long? or something I
miss....

Not _all_ of them, we have some that count bytes.  But those counting
pages should probably be ulong, yes.

I think Kame added the ones that you wanted to adjust the surroundings
for in particular, so let's ask him.  Kame?

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>