On 06/22/2012 05:58 AM, Peter Zijlstra wrote:

On Thu, 2012-06-21 at 17:57 -0400, Rik van Riel wrote:

quoted

@@ -1941,6 +2017,8 @@ detach_vmas_to_be_unmapped(struct mm_struct *mm, struct vm_area_struct *vma,
         *insertion_point = vma;
         if (vma)
                 vma->vm_prev = prev;
+       if (vma)
+               rb_augment_erase_end(&vma->vm_rb, vma_rb_augment_cb, NULL);

Shouldn't that be adjust_free_gap()? There is after all no actual erase
happening.

You are right. I will fix this and also adjust the comment
above adjust_free_gap().

I am still trying to wrap my brain around your alternative
search algorithm, not sure if/how it can be combined with
arbitrary address limits and alignment...

-- 
All rights reversed

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>