Re: [PATCH 1/4] fs: Remove bogus wait in write_inode_now()
From: Christoph Hellwig <hch@infradead.org>
Date: 2012-03-19 06:57:39
Also in:
linux-fsdevel, lkml
From: Christoph Hellwig <hch@infradead.org>
Date: 2012-03-19 06:57:39
Also in:
linux-fsdevel, lkml
On Fri, Mar 09, 2012 at 10:02:25AM +0100, Jan Kara wrote:
inode_sync_wait() in write_inode_now() is just bogus. That function waits for I_SYNC bit to be cleared but writeback_single_inode() clears the bit on return so the wait is effectivelly a nop unless someone else submits the inode for writeback again. All the waiting write_inode_now() needs is achieved by using WB_SYNC_ALL writeback mode. Signed-off-by: Jan Kara <jack@suse.cz>
Loks good - I have the same in my patchkit to kill write_inode_now (which I really need to get out soon). Signed-off-by: Christoph Hellwig <hch@lst.de> -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>