Re: [PATCH] fadvise: avoid EINVAL if user input is valid
From: Pádraig Brady <hidden>
Date: 2012-02-25 22:56:25
Also in:
lkml
On 02/25/2012 02:27 AM, Eric Wong wrote:
The kernel is not required to act on fadvise, so fail silently and ignore advice as long as it has a valid descriptor and parameters.
quoted hunk ↗ jump to hunk
@@ -106,12 +105,8 @@ SYSCALL_DEFINE(fadvise64_64)(int fd, loff_t offset, loff_t len, int advice) nrpages = end_index - start_index + 1; if (!nrpages) nrpages = ~0UL; - - ret = force_page_cache_readahead(mapping, file, - start_index, - nrpages); - if (ret > 0) - ret = 0; + + force_page_cache_readahead(mapping, file, start_index, nrpages); break;
This whole patch makes sense to me. The above chunk might cause confusion in future, if people wonder for a moment why the return is ignored. Should you use cast with (void) like this to be explicit? (void) force_page_cache_readahead(...); cheers, Padraig. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>