Re: [PATCH v5 1/8] smp: Introduce a generic on_each_cpu_mask function
From: Michal Nazarewicz <hidden>
Date: 2012-01-03 07:51:40
Also in:
linux-fsdevel, lkml
On Mon, 02 Jan 2012 11:24:12 +0100, Gilad Ben-Yossef [off-list ref] wrote:
quoted hunk ↗ jump to hunk
@@ -102,6 +102,13 @@ static inline void call_function_init(void) { } int on_each_cpu(smp_call_func_t func, void *info, int wait);/* + * Call a function on processors specified by mask, which might include + * the local one. + */ +void on_each_cpu_mask(const struct cpumask *mask, void (*func)(void *), + void *info, bool wait); +
on_each_cpu() returns an int. For consistency reasons, would it make sense to make on_each_cpu_maks() to return and int? I know that the difference is that smp_call_function() returns and int and smp_call_function_many() returns void, but to me it actually seems strange and either I'm missing something important (which is likely) or this needs to get cleaned up at one point as well.
+/* * Mark the boot cpu "online" so that it can call console drivers in * printk() and can access its per-cpu storage. */
-- Best regards, _ _ .o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o ..o | Computer Science, Michał “mina86” Nazarewicz (o o) ooo +----<email/xmpp: mpn@google.com>--------------ooO--(_)--Ooo-- -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>