Thread (12 messages) 12 messages, 4 authors, 2012-01-30

Re: [PATCH v3 -mm 1/3] mm: reclaim at order 0 when compaction is enabled

From: Rik van Riel <hidden>
Date: 2012-01-27 16:35:37
Also in: lkml

On 01/27/2012 04:13 AM, Hillf Danton wrote:
quoted
@@ -1195,7 +1195,7 @@ static unsigned long isolate_lru_pages(unsigned long nr_to_scan,
                        BUG();
                }

-               if (!order)
+               if (!sc->order || !(sc->reclaim_mode&  RECLAIM_MODE_LUMPYRECLAIM))
                        continue;
Just a tiny advice 8-)

mind to move checking lumpy reclaim out of the loop,
something like
Hehe, I made the change the way it is on request
of Mel Gorman :)

I don't particularly care either way and will be
happy to make the code whichever way people prefer.

Just let me know.

-- 
All rights reversed

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help