Re: [PATCH v4] memcg: remove PCG_CACHE page_cgroup flag
From: Johannes Weiner <hannes@cmpxchg.org>
Date: 2012-01-24 11:16:57
Also in:
lkml
On Tue, Jan 24, 2012 at 12:16:36PM +0900, KAMEZAWA Hiroyuki wrote:
quoted
Can we make this anon as well?I'm sorry for long RTT. version 4 here. ==quoted
From c40256561d6cdaee62be7ec34147e6079dc426f4 Mon Sep 17 00:00:00 2001From: KAMEZAWA Hiroyuki <redacted> Date: Thu, 19 Jan 2012 17:09:41 +0900 Subject: [PATCH] memcg: remove PCG_CACHE We record 'the page is cache' by PCG_CACHE bit to page_cgroup. Here, "CACHE" means anonymous user pages (and SwapCache). This doesn't include shmem.
!CACHE means anonymous/swapcache
Consdering callers, at charge/uncharge, the caller should know what the page is and we don't need to record it by using 1bit per page. This patch removes PCG_CACHE bit and make callers of mem_cgroup_charge_statistics() to specify what the page is. Changelog since v3 - renamed a variable 'rss' to 'anon' Changelog since v2 - removed 'not_rss', added 'anon' - changed a meaning of arguments to mem_cgroup_charge_statisitcs() - removed a patch to mem_cgroup_uncharge_cache - simplified comment. Changelog since RFC. - rebased onto memcg-devel - rename 'file' to 'not_rss' - some cleanup and added comment. Signed-off-by: KAMEZAWA Hiroyuki <redacted>
Acked-by: Johannes Weiner <hannes@cmpxchg.org> -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>