Thread (26 messages) 26 messages, 7 authors, 2012-01-05
STALE5312d

[PATCH 2/3] mm: cond_resched in scan_mapping_unevictable_pages

From: Hugh Dickins <hughd@google.com>
Date: 2011-12-29 04:36:57

scan_mapping_unevictable_pages() is used to make SysV SHM_LOCKed pages
evictable again once the shared memory is unlocked or destroyed (the
latter seems rather a waste of time, but meets internal expectations).
It does pagevec_lookup()s across the whole object: methinks a
cond_resched() every PAGEVEC_SIZE pages would be worthwhile.

Signed-off-by: Hugh Dickins <hughd@google.com>
---
 mm/vmscan.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
--- mmotm.orig/mm/vmscan.c	2011-12-28 16:49:36.000000000 -0800
+++ mmotm/mm/vmscan.c	2011-12-28 17:03:07.647220248 -0800
@@ -3583,8 +3583,8 @@ void scan_mapping_unevictable_pages(stru
 		pagevec_release(&pvec);
 
 		count_vm_events(UNEVICTABLE_PGSCANNED, pg_scanned);
+		cond_resched();
 	}
-
 }
 
 static void warn_scan_unevictable_pages(void)

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help